Materialize buoyancy gradients for use in parameterizations #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
added
the
benchmark performance
glwagner
reviewed
Oct 9, 2025
src/Models/HydrostaticFreeSurfaceModels/hydrostatic_free_surface_model.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Oct 9, 2025
glwagner
reviewed
Oct 9, 2025
| arch = architecture(grid) | ||
|
|
||
| # Maybe compute buoyancy gradients | ||
| compute_buoyancy_gradients!(buoyancy, grid, tracers; parameters = κ_parameters) |
There was a problem hiding this comment.
why does it take "κ_parameters"? These are the parameters for the turbulence closure? It's not clear why we would use that.
There was a problem hiding this comment.
right, I think we need some interior_parameters and surface_parameters.
glwagner
reviewed
Oct 9, 2025
glwagner
approved these changes
Oct 9, 2025
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
…ce_model.jl Co-authored-by: Gregory L. Wagner <[email protected]>
glwagner
changed the title
|
The difference between main and this PR is staggering for all the CATKE functions On mainCATKE was the most expensive kernel On this PRTendencies take back their role of most heavy computations in the model |
I will merge this PR and open a new PR immediately to fix the parameter naming (which I was already doing in #4811) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the precomputation of buoyancy gradients, which are required for most parameterization.
By doing this, we avoid heavyl interpolation of buoyancy computations (for example in slope computations or in Richardson number computations) speeding up significantly the parameterizations.